fix(app): render interpolated button labels as one text node - #194
Open
simonvanlierde wants to merge 2 commits into
Open
fix(app): render interpolated button labels as one text node#194simonvanlierde wants to merge 2 commits into
simonvanlierde wants to merge 2 commits into
Conversation
- AppButton wraps an all-primitive child run in a single Text, so
"Select all ({count})" no longer splits into three gapped nodes
- renovate: force vulnerabilityAlerts.enabled so alerts still raise PRs
for the Expo-owned packages that are otherwise disabled
- test setup: drop the unawaited manual cleanup(); RNTL 14 registers its own
- test-utils/host: use container.queryAll instead of a hand-rolled walk
that also returned the container
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-ups from the pre-release review of v0.3.0..main.
Text, so "Select all ({count})" no longer splits into three gapped nodes (visual gaps, three screen-reader fragments,getByTextmiss). Regression test added.vulnerabilityAlerts.enabled: trueso alert PRs still open for the Expo-owned packages whose rule isenabled: false(Renovate only forces the keys present invulnerabilityAlerts; without it those deps are skipped before lookup).cleanup(); RNTL 14 registers its own awaited one.test-utils/host: usecontainer.queryAllinstead of a hand-rolled walk that also returned the container.Verification: app
just check, unit (1615) and integration (203) lanes green.